[PATCH v3 2/4] usb: dwc3: Add Google Tensor SoC DWC3 glue driver

Thinh Nguyen Thinh.Nguyen at synopsys.com
Tue Oct 14 17:27:51 PDT 2025


Hi,

On Fri, Oct 10, 2025, Roy Luo wrote:
> +#endif /* CONFIG_PM */
> +
> +static const struct dev_pm_ops dwc3_google_dev_pm_ops = {
> +	SET_SYSTEM_SLEEP_PM_OPS(dwc3_google_pm_suspend, dwc3_google_pm_resume)
> +	SET_RUNTIME_PM_OPS(dwc3_google_runtime_suspend, dwc3_google_runtime_resume,
> +			   dwc3_google_runtime_idle)

Can we use the new pm_ptr() and *_PM_OPS macros to get rid of the ifdef
CONFIG_PM guards?

> +	.complete = dwc3_google_complete,
> +	.prepare = dwc3_google_prepare,
> +};
> +
> +static const struct of_device_id dwc3_google_of_match[] = {
> +	{ .compatible = "google,gs5-dwc3" },
> +	{ }
> +};
> +MODULE_DEVICE_TABLE(of, dwc3_google_of_match);
> +
> +static struct platform_driver dwc3_google_driver = {
> +	.probe		= dwc3_google_probe,
> +	.remove		= dwc3_google_remove,
> +	.driver		= {
> +		.name	= "google-dwc3",
> +		.pm	= &dwc3_google_dev_pm_ops,
> +		.of_match_table	= dwc3_google_of_match,
> +	},
> +};
> +
> +module_platform_driver(dwc3_google_driver);
> +MODULE_LICENSE("GPL");
> +MODULE_DESCRIPTION("DesignWare DWC3 Google Glue Driver");
> -- 
> 2.51.0.740.g6adb054d12-goog
> 

Give me some time, and I'll review the rest of this patch.

Thanks,
Thinh


More information about the linux-arm-kernel mailing list