[PATCH 8/8] firmware: imx: scu: Use devm_mutex_init

Frank Li Frank.li at nxp.com
Tue Oct 14 09:02:26 PDT 2025


On Tue, Oct 14, 2025 at 12:54:45PM +0800, Peng Fan wrote:
> In normal case, there is no need to invoke mutex_destroy in error path,
> but it is useful when CONFIG_DEBUG_MUTEXES, so use devm_mutex_init().
>
> Signed-off-by: Peng Fan <peng.fan at nxp.com>
> ---

Reviewed-by: Frank Li <Frank.Li at nxp.com>

>  drivers/firmware/imx/imx-scu.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/firmware/imx/imx-scu.c b/drivers/firmware/imx/imx-scu.c
> index 630e3dba4db15961ae4d77273af6248be614145e..67b267a7408a12deed77d2c8f52d5f64b239a408 100644
> --- a/drivers/firmware/imx/imx-scu.c
> +++ b/drivers/firmware/imx/imx-scu.c
> @@ -324,7 +324,9 @@ static int imx_scu_probe(struct platform_device *pdev)
>  	}
>
>  	sc_ipc->dev = dev;
> -	mutex_init(&sc_ipc->lock);
> +	ret = devm_mutex_init(dev, &sc_ipc->lock);
> +	if (ret)
> +		return ret;
>  	init_completion(&sc_ipc->done);
>
>  	imx_sc_ipc_handle = sc_ipc;
>
> --
> 2.37.1
>



More information about the linux-arm-kernel mailing list