[PATCH v5 3/3] arm64: dts: rockchip: add LinkEase EasePi R1

Chukun Pan amadeus at jmu.edu.cn
Mon Oct 13 06:00:10 PDT 2025


Hi,

> +&pinctrl {
> +	gmac0 {
> +		eth_phy0_reset_pin: eth-phy0-reset-pin {
> +			rockchip,pins = <2 RK_PD3 RK_FUNC_GPIO &pcfg_pull_up>;
> +		};
> +	};

Leave a blank line.

> +	gmac1 {
> +		eth_phy1_reset_pin: eth-phy1-reset-pin {
> +			rockchip,pins = <2 RK_PD1 RK_FUNC_GPIO &pcfg_pull_up>;
> +		};
> +	};

> +	gpio-leds {
> +		status_led_pin: status-led-pin {
> +			rockchip,pins =

No line break required here.

> +				<2 RK_PD7 RK_FUNC_GPIO &pcfg_pull_none>;
> +		};
> +	};

> VBUS on usb2phy0_otg is floating, this USB port only works on
> device (peripheral) mode.
> phy-supply is optional, so this should be fine, right?

Yes, if there is no log like this:
supply phy not found, using dummy regulator



More information about the linux-arm-kernel mailing list