[PATCH v2] driver core: fw_devlink: Don't warn about sync_state() pending

Ulf Hansson ulf.hansson at linaro.org
Tue Oct 7 02:43:12 PDT 2025


Due to the wider deployment of the ->sync_state() support, for PM domains
for example, we are receiving reports about the sync_state() pending
message that is being logged in fw_devlink_dev_sync_state(). In particular
as it's printed at the warning level, which is questionable.

Even if it certainly is useful to know that the ->sync_state() condition
could not be met, there may be nothing wrong with it. For example, a driver
may be built as module and are still waiting to be initialized/probed. For
this reason let's move to the info level for now.

Reported-by: Geert Uytterhoeven <geert at linux-m68k.org>
Reported-by: Sebin Francis <sebin.francis at ti.com>
Reported-by: Diederik de Haas <didi.debian at cknow.org>
Reported-by: Jon Hunter <jonathanh at nvidia.com>
Reviewed-by: Tomi Valkeinen <tomi.valkeinen at ideasonboard.com>
Signed-off-by: Ulf Hansson <ulf.hansson at linaro.org>
---

Changes in v2:
	- Due to discussions on v1 and because the default Kconfig is to use the
	FW_DEVLINK_SYNC_STATE_STRICT, I suggest that for now it may be best to
	keep the warning level for the "Timed out.." print and only change the
	"sync_state pending..." message.

---
 drivers/base/core.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/base/core.c b/drivers/base/core.c
index d22d6b23e758..c62e428b95b0 100644
--- a/drivers/base/core.c
+++ b/drivers/base/core.c
@@ -1784,7 +1784,7 @@ static int fw_devlink_dev_sync_state(struct device *dev, void *data)
 		return 0;
 
 	if (fw_devlink_sync_state == FW_DEVLINK_SYNC_STATE_STRICT) {
-		dev_warn(sup, "sync_state() pending due to %s\n",
+		dev_info(sup, "sync_state() pending due to %s\n",
 			 dev_name(link->consumer));
 		return 0;
 	}
-- 
2.43.0




More information about the linux-arm-kernel mailing list