[PATCH v3 4/6] dt-bindings: display: mediatek: disp-tdshp: Add support for MT8196

[Krzysztof Kozlowski]

On 21/09/2025 13:39, Jay Liu (刘博) wrote:
>>> +
>>> +maintainers:
>>> +  - Chun-Kuang Hu <chunkuang.hu at kernel.org>
>>> +  - Philipp Zabel <p.zabel at pengutronix.de>
>>> +
>>> +description: |
>>> +  MediaTek display 2D sharpness processor, namely TDSHP, provides
>>> a
>>> +  operation used to adjust sharpness in display system.
>>> +  TDSHP device node must be siblings to the central MMSYS_CONFIG
>>> node.
>>
>> Heh? Why would this have to be a sibling? This is really odd, because
>> you cannto actually rely on that.
>>
> hi Krzysztof,
> disp-tdshp is one of components of display pipeline. just like OVL,
> color, etc. MMSYS_CONFIG controls the clock of display pipeline,


Read feedback again.

Unfortunately Mediatek produces way too many poor quality patches and
review has so many obstacles like not addressing the comments. Example
above. You need to pay more attention and invest more time, before
pinging or replying to maintainers.

> 
>> You just added unverifiable unusual ABI with no explanation.

Best regards,
Krzysztof