[PATCH] PCI: brcmstb: Fix use of incorrect constant

Florian Fainelli florian.fainelli at broadcom.com
Mon Oct 6 12:35:19 PDT 2025



On 10/3/2025 10:04 AM, Jim Quinlan wrote:
> The driver was using the PCIE_LINK_STATE_L1 constant as a field mask for
> setting the private PCI_EXP_LNKCAP register, but this constant is
> Linux-created and has nothing to do with the PCIe spec.  Serendipitously,
> the value of this constant was correct for its usage until after 6.1, when
> its value changed from BIT(1) to BIT(2);
> 
> In addition, the driver was assuming that the HW is ASPM L1 capable when it
> should not be telling the HW what it is capable of.
> 
> Fixes: caab002d5069 ("PCI: brcmstb: Disable L0s component of ASPM if requested")
> Reported-by: Bjorn Helgaas <bhelgaas at google.com>
> 
> Signed-off-by: Jim Quinlan <james.quinlan at broadcom.com>

Reviewed-by: Florian Fainelli <florian.fainelli at broadcom.com>
-- 
Florian




More information about the linux-arm-kernel mailing list