[PATCH v3 2/2] ARM: dts: Add support for pcb8385

[Horatiu Vultur]

The 11/28/2025 10:08, Krzysztof Kozlowski wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
> 
> On 27/11/2025 10:24, Horatiu Vultur wrote:
> > The 11/26/2025 11:24, Krzysztof Kozlowski wrote:
> >>
> >
> > Hi Krzysztof,
> >
> >>> +
> >>> +&flx0 {
> >>> +     atmel,flexcom-mode = <ATMEL_FLEXCOM_MODE_TWI>;
> >>> +     status = "okay";
> >>> +
> >>> +     i2c0: i2c at 600 {
> >>
> >> You added a label, so this feels like a new node, but then you miss
> >> compatible and status feels redundant.
> >
> > Ah.. OK. I didn't want to add a new node.
> >
> >>
> >> If this is override, you should rather override by labels/phandles in
> >> the first place. Even when overriding by full node path, you should not
> >> add custom labels - they belong to the base SoC.
> >
> > I can remove the label.
> > So, when I want to override or extend with new properties I should
> > labels?
> 
> 
> Yes, child of serial engine should still be extended by label/phandle,
> unless this SoC subsystem has different rule.

What do you mean by "child of serial engine"?

> 
> Best regards,
> Krzysztof

-- 
/Horatiu