[PATCH v2 2/3] ARM: dts: exynos: Add Google Manta (Nexus 10)

[Krzysztof Kozlowski]

On 27/11/2025 21:01, Lukas Timmermann wrote:
>>> +
>>> +		lid-switch {
>>> +			label = "Lid";
>>> +			gpios = <&gpx1 3 GPIO_ACTIVE_LOW>;
>>> +			linux,input-type = <5>; /* EV_SW */
>>> +			linux,code = <0>; /* SW_LID */
>>> +			debounce-interval = <10>;
>>> +			wakeup-source;
>>> +		};
>>> +	};
>>> +
>>> +	multi-led {
>>> +		compatible = "leds-group-multicolor";
>>> +		color = <LED_COLOR_ID_RGB>;
>>> +		function = LED_FUNCTION_STATUS;
>>> +		leds = <&status_red>, <&status_green>, <&status_blue>, <&status_white>;
>>> +	};
>>> +
>>> +	wlan_pwrseq: mmc1-pwrseq {
>>
>> Just "pwrseq"
>>
> Acknowledged.
> Just out of curiosity. Why is that?


You have only one pwrseq device, so not need to precise which one is
that and node names should be generic.

https://devicetree-specification.readthedocs.io/en/latest/chapter2-devicetree-basics.html#generic-names-recommendation

Best regards,
Krzysztof