[PATCH 1/2] dt-bindings: usb: aspeed,usb-vhub: Add ast2700 support

Ryan Chen ryan_chen at aspeedtech.com
Wed Nov 26 16:42:03 PST 2025


> Subject: Re: [PATCH 1/2] dt-bindings: usb: aspeed,usb-vhub: Add ast2700
> support
> 
> On Wed, Nov 26, 2025 at 04:26:30PM +0800, Ryan Chen wrote:
> > Add the "aspeed,ast2700-usb-vhub" compatible. The ast2700 vhub
> > controller requires an reset, so make the "resets" property mandatory
> > for this compatible to reflect the hardware requirement.
> >
> > Signed-off-by: Ryan Chen <ryan_chen at aspeedtech.com>
> > ---
> >  Documentation/devicetree/bindings/usb/aspeed,usb-vhub.yaml | 14
> > ++++++++++++++
> >  1 file changed, 14 insertions(+)
> >
> > diff --git
> > a/Documentation/devicetree/bindings/usb/aspeed,usb-vhub.yaml
> > b/Documentation/devicetree/bindings/usb/aspeed,usb-vhub.yaml
> > index 7f22f9c031b2..c9ebb6e004d1 100644
> > --- a/Documentation/devicetree/bindings/usb/aspeed,usb-vhub.yaml
> > +++ b/Documentation/devicetree/bindings/usb/aspeed,usb-vhub.yaml
> > @@ -26,6 +26,7 @@ properties:
> >        - aspeed,ast2400-usb-vhub
> >        - aspeed,ast2500-usb-vhub
> >        - aspeed,ast2600-usb-vhub
> > +      - aspeed,ast2700-usb-vhub
> >
> >    reg:
> >      maxItems: 1
> > @@ -33,6 +34,9 @@ properties:
> >    clocks:
> >      maxItems: 1
> >
> > +  resets:
> > +    maxItems: 1
> > +
> >    interrupts:
> >      maxItems: 1
> >
> > @@ -107,6 +111,16 @@ required:
> >    - aspeed,vhub-downstream-ports
> >    - aspeed,vhub-generic-endpoints
> >
> > +if:
> > +  properties:
> > +    compatible:
> > +      contains:
> > +        const: aspeed,ast2700-usb-vhub
> > +
> > +then:
> > +  required:
> > +    - resets
> 
> Do other aspeed platforms have resets? If not, please add an else here to block
> its use on other platforms.

I will update to following. 

   if:
      properties:
        compatible:
          contains:
            const: aspeed,ast2700-usb-vhub
    then:
      required:
        - resets

    else:
      properties:
        resets: false

Thanks your review.
> 
> > +
> >  additionalProperties: false
> >
> >  examples:
> >
> > --
> > 2.34.1
> >



More information about the linux-arm-kernel mailing list