[PATCH v4 2/2] dts: aspeed: Add a dts for the nvidia msx4 hpm
Andrew Jeffery
andrew at codeconstruct.com.au
Wed Nov 26 16:09:22 PST 2025
Hi Marc,
On Mon, 2025-11-24 at 15:14 -0800, Marc Olberding wrote:
> Adds a dts for the nvidia mgx pcie switchboard reference
> platformi hpm. This is a dual socket granite rapids based platform.
I was looking to apply this, and set about tweaking the commit message
in the process, but the more I tweaked the more I felt I needed to
tweak. So rather than do all that myself, I'll ask that you work
through these requests :)
The things that I'd like addressed are:
1. The subject prefix needs to begin with "ARM: ", so:
ARM: dts: aspeed: ...
2. I'd rather stick to formalised naming and capitalisation, so NVIDIA,
MSX4, and HPM, Granite Rapids etc
3. "Add a dts for" in the subject is a bit redundant, as we already
have "dts" in the prefix. We can trim that out:
ARM: dts: aspeed: Add NVIDIA MSX4 HPM platform
4. "HPM" hasn't yet been expanded anywhere and it's still a mystery to
me. Can we unpack that in the commit message?
5. "Adds a dts for ..." in the commit message is self-evident from the
patch. Rather, can you please talk a bit more about the purpose of the
platform? I'd like to see discussion of its use cases and any
interesting points of design or implementation.
Cheers,
Andrew
More information about the linux-arm-kernel
mailing list