[PATCH 2/2] ARM: dts: Add support for pcb8385

[Horatiu Vultur]

The 11/22/2025 16:21, Claudiu Beznea wrote:
> 
> Hi, Horatiu,

Hi Claudiu,

> 

> > +&flx0 {
> 
> This would go after aes node to have them alphanumerically sorted. I can
> handled it while applying, if any.

Yes, I make sure that the nodes are sorted alphanumerically.

> 
> > +     atmel,flexcom-mode = <ATMEL_FLEXCOM_MODE_TWI>;
> > +     status = "okay";
> > +
> > +     i2c0: i2c at 600 {
> > +             pinctrl-0 = <&fc0_b_pins>;
> > +             pinctrl-names = "default";
> > +             dmas = <0>, <0>;
> > +             i2c-analog-filter;
> > +             i2c-digital-filter;
> > +             i2c-digital-filter-width-ns = <35>;
> > +             i2c-sda-hold-time-ns = <1500>;
> > +             status = "okay";
> > +     };
> > +};

...

> > +&i2c0 {
> > +     eeprom at 54 {
> > +             compatible = "atmel,24c01";
> > +             reg = <0x54>;
> > +             status = "okay";
> > +     };
> > +
> > +     eeprom at 55 {
> > +             compatible = "atmel,24c01";
> > +             reg = <0x55>;
> > +             status = "okay";
> > +     };
> 
> Any reason for not keeping these above under "i2c0: i2c at 600 {" ?

Not really. I will move them there.

> 
> Thank you,
> Claudiu
> 
> > +};
> > +
> > +&sgpio {
> > +     pinctrl-0 = <&sgpio_a_pins>;
> > +     pinctrl-names = "default";
> > +     microchip,sgpio-port-ranges = <0 3>;
> > +     status = "okay";
> > +
> > +     gpio at 0 {
> > +             ngpios = <64>;
> > +     };
> > +     gpio at 1 {
> > +             ngpios = <64>;
> > +     };
> > +};
> 

-- 
/Horatiu