[PATCH net-next] net: stmmac: move stmmac_mac_finish() after stmmac_mac_config()
Maxime Chevallier
maxime.chevallier at bootlin.com
Fri Nov 21 04:03:59 PST 2025
Hi Russell,
On 21/11/2025 10:52, Russell King (Oracle) wrote:
> Keep the functions and initialisers in the same order that they exist
> in phylink_mac_ops. This is the preferred order for phylink methods
> as it arranges the configuration methods by called order.
>
> Signed-off-by: Russell King (Oracle) <rmk+kernel at armlinux.org.uk>
> ---
> drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
> index 970c670fc302..d16e522c1e7d 100644
> --- a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
> +++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
> @@ -932,7 +932,8 @@ static int stmmac_mac_finish(struct phylink_config *config, unsigned int mode,
> struct stmmac_priv *priv = netdev_priv(ndev);
>
> if (priv->plat->mac_finish)
> - priv->plat->mac_finish(ndev, priv->plat->bsp_priv, mode, interface);
> + priv->plat->mac_finish(ndev, priv->plat->bsp_priv, mode,
> + interface);
This is just a line wrap, I don't really see the connexion with the
commit log :( Some missing hunks in the commit maybe ?
Maxime
>
> return 0;
> }
More information about the linux-arm-kernel
mailing list