[PATCH net-next v2 0/3] net: stmmac: qcon-ethqos: "rgmii" accessor cleanups

Russell King (Oracle) linux at armlinux.org.uk
Thu Nov 20 03:24:59 PST 2025


This series cleans up the "rgmii" accessors in qcom-ethqos.

readl() and writel() return and take a u32 for the value. Rather than
implicitly casting this to an int, keep it as a u32.

Add set/clear functions to reduce the code and make it easier to read.

Finally, convert the open-coded poll loops to use the iopoll helpers.

Note that patch 1 has a checkpatch warning concerning "volatile" - I'm
changing the type here, and the "volatile" is removed in patch 3. I do
not feel it is appropriate to remove it in patch 1.

v2:
 - remove double-spaces in patch 2.

 .../ethernet/stmicro/stmmac/dwmac-qcom-ethqos.c    | 245 +++++++++------------
 1 file changed, 110 insertions(+), 135 deletions(-)

-- 
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!



More information about the linux-arm-kernel mailing list