[PATCH v3 05/15] gpio: pxa: Use modern PM macros
Andy Shevchenko
andriy.shevchenko at intel.com
Wed Nov 19 08:25:58 PST 2025
On Wed, Nov 19, 2025 at 11:58:19PM +0800, Jisheng Zhang wrote:
> On Wed, Nov 19, 2025 at 05:47:41PM +0200, Andy Shevchenko wrote:
> > On Wed, Nov 19, 2025 at 10:43:17PM +0800, Jisheng Zhang wrote:
...
> > > -#ifdef CONFIG_PM
> > > unsigned long saved_gplr;
> > > unsigned long saved_gpdr;
> > > unsigned long saved_grer;
> > > unsigned long saved_gfer;
> > > -#endif
> >
> > Same Q as per dwapb driver. The CONFIG_PM=n doesn't need these.
>
> Now, I know why you commented like these...
> the pm_ptr() and pm_sleep_ptr() can optimize out the PM
> functions, but those functions still need to be compiled. So if
> we keep these #ifdef, there will be build errors in case of !PM
My bad. I haven't realised that it's not just being discarded...
Thanks for your patience. Then please, fix the typos and we will go
with the v4.
--
With Best Regards,
Andy Shevchenko
More information about the linux-arm-kernel
mailing list