[PATCH v2 1/2] dt-bindings: arm: rockchip: Add Asus Tinker Board 3 and 3S
Michael Opdenacker
michael.opdenacker at rootcommit.com
Tue Nov 18 23:25:37 PST 2025
Hi Dragan
Thanks for your reviews in busy times!
> This should let us keep the "asus,rk3566-tinker-board-3" compatible
> in the new rk3566-tinker-board-3s.dts board dts while satisfying the
> validation properly:
>
> - description: Asus Tinker Board 3/3S
> items:
> - enum:
> - asus,rk3566-tinker-board-3s
> - const: asus,rk3566-tinker-board-3
> - const: rockchip,rk3566
>
> I'm quite busy at the moment, hence my delayed response, and I also
> apologize for not running the checks on the above-proposed solution,
> but I think it should work as expected.
I actually already tried this, but it doesn't pass "make dtbs_check":
arch/arm64/boot/dts/rockchip/rk3566-tinker-board-3.dtb: /
(asus,rk3566-tinker-board-3): compatible: 'oneOf' conditional failed,
one must be fixed:
['asus,rk3566-tinker-board-3', 'rockchip,rk3566'] is too short
The "enum" statement seems to mean that there is at least one of the
items, which is not the case for rk3566-tinker-board-3.dts that doesn't
have it.
So, my V3 seems like the way to go if we don't want to duplicate entries
in rockchip.yaml.
Cheers
Michael.
--
Michael Opdenacker
Root Commit
Yocto Project and OpenEmbedded Training course - Learn by doing:
https://rootcommit.com/training/yocto/
More information about the linux-arm-kernel
mailing list