[PATCH v5 5/5] pci: Suspend iommu function prior to resetting a device
Nicolin Chen
nicolinc at nvidia.com
Tue Nov 18 00:17:24 PST 2025
On Tue, Nov 18, 2025 at 07:53:27AM +0000, Tian, Kevin wrote:
> > From: Nicolin Chen <nicolinc at nvidia.com>
> > And how do you think of the followings?
> >
> > /*
> > * Per PCIe r6.3, sec 10.3.1 IMPLEMENTATION NOTE, software disables ATS
> > before
> > * initiating a reset. Though not all IOMMU drivers calls pci_enable_ats(), it
> > * only gets invoked in IOMMU driver. And it is racy to check dev-
> > >ats_enabled
> > * here, as a concurrent IOMMU attachment can enable ATS right after this
> > line.
> > *
> > * Notify the IOMMU driver to stop IOMMU translations until the reset is
> > done,
> > * to ensure that the ATS function and its related invalidations are disabled.
> > */
> >
>
> I'd remove the words between "Though not ..." and "after this line", which
> could be explained in iommu side following Bjorn's suggestion to not check
> pci_ats_supported() in pci core.
OK. Thanks!
Nicolin
More information about the linux-arm-kernel
mailing list