Re: [PATCH 2/3] PCI: rockchip-host: comment danger of 5.0 GT/s speed

[Dragan Simic]

On Saturday, November 15, 2025 11:04 CET, Geraldo Nascimento <geraldogabriel at gmail.com> wrote:
> On Sat, Nov 15, 2025 at 11:01:21AM +0100, Dragan Simic wrote:
> > On Saturday, November 15, 2025 10:51 CET, Geraldo Nascimento <geraldogabriel at gmail.com> wrote:
> > > On Sat, Nov 15, 2025 at 10:30:49AM +0100, Dragan Simic wrote:
> > > > Looking good to me, thanks for this patch!  There's no need
> > > > to emit warnings here, because they'd be emitted already in
> > > > the rockchip_pcie_parse_dt() function.
> > > > 
> > > > Please feel free to include
> > > > 
> > > > Reviewed-by: Dragan Simic <dsimic at manjaro.org>
> > > >
> > > 
> > > I disagree, I think the comment stands.
> > > 
> > > Even if we reduce to one line, ex:
> > > 
> > > + May cause damage
> > 
> > Ah, perhaps I wasn't clear enough, so let me clarify a bit.  The
> > comment you added is fine, I just referred to no need for emitting
> > a warning at that point, because it would be emitted already.
> 
> OK, I get it now so I think it's time to send v2 with all that in mind
> :)

Please, wait a day or two before sending the v2, because that's
standard procedure.  Sending more than one version in the same day
is highly discouraged, because it doesn't give enough time to people
for reviewing, and may cause people to look at a wrong version.