[PATCH 2/4] PCI: tegra194: Remove unnecessary L1SS disable code
Niklas Cassel
cassel at kernel.org
Wed Nov 12 00:29:20 PST 2025
On Tue, Nov 11, 2025 at 04:16:09PM -0600, Bjorn Helgaas wrote:
> From: Bjorn Helgaas <bhelgaas at google.com>
>
> The DWC core clears the L1 Substates Supported bits unless the driver sets
> the "dw_pcie.l1ss_support" flag.
>
> The tegra194 init_host_aspm() sets "dw_pcie.l1ss_support" if the platform
> has the "supports-clkreq" DT property. If "supports-clkreq" is absent,
> "dw_pcie.l1ss_support" is not set, and the DWC core will clear the L1
> Substates Supported bits.
>
> The tegra194 code to clear the L1 Substates Supported bits is unnecessary,
> so remove it.
>
> Signed-off-by: Bjorn Helgaas <bhelgaas at google.com>
> ---
Since init_host_aspm() is now the only place using struct tegra_pcie_dw
struct member cfg_link_cap_l1sub, I think that you can remove this struct
member, and instead make this a local variable in init_host_aspm().
Other than that, looks good to me:
Reviewed-by: Niklas Cassel <cassel at kernel.org>
More information about the linux-arm-kernel
mailing list