回复: [PATCH 2/3] Reset: cix: add support for cix sky1 resets

[Gary Yang]

Hi Krzysztof:

> -----邮件原件-----
> 发件人: Krzysztof Kozlowski <krzk at kernel.org>
> 发送时间: 2025年11月7日 15:19
> 收件人: Gary Yang <gary.yang at cixtech.com>; p.zabel at pengutronix.de;
> robh at kernel.org; krzk+dt at kernel.org; conor+dt at kernel.org
> 抄送: devicetree at vger.kernel.org; linux-kernel at vger.kernel.org;
> linux-arm-kernel at lists.infradead.org; cix-kernel-upstream
> <cix-kernel-upstream at cixtech.com>
> 主题: Re: [PATCH 2/3] Reset: cix: add support for cix sky1 resets
> 
> EXTERNAL EMAIL
> 
> On 07/11/2025 04:38, Gary Yang wrote:
> > There are two reset controllers on Cix Sky1 Soc.
> > One is located in S0 domain, and the other is located in S5 domain.
> >
> > Signed-off-by: Gary Yang <gary.yang at cixtech.com>
> 
> Please use subject prefixes matching the subsystem. You can get them for
> example with `git log --oneline -- DIRECTORY_OR_FILE` on the directory your
> patch is touching. For bindings, the preferred subjects are explained here:
> https://www.kernel.org/doc/html/latest/devicetree/bindings/submitting-patch
> es.html#i-for-patch-submitters
> 
> It is not "Reset:". Mark capitals.
> 

OK, We will use "reset:" instead of it

> > ---
> 
> 
> ...
> 
> > +static struct platform_driver sky1_reset_driver = {
> > +     .probe  = sky1_reset_probe,
> > +     .driver = {
> > +             .name           = KBUILD_MODNAME,
> > +             .of_match_table = sky1_reset_dt_ids,
> > +     },
> > +};
> > +static int __init reset_sky1_init(void) {
> > +     return platform_driver_register(&sky1_reset_driver);
> > +}
> > +subsys_initcall(reset_sky1_init);
> 
> This should be rather just module_platform_driver. Does not look like part of
> subsystem, but looks like regular driver.
> 

Some modules depend reset module. When boot system, these modules can't probe before register reset.
To make these modules probe earlier, we use subsys_initcall() to instead of module_platform_driver(). Do you
have better suggestions?

Best wishes
Gary

> > +
> > +static void __exit reset_sky1_exit(void) {
> > +     platform_driver_unregister(&sky1_reset_driver);
> > +}
> > +module_exit(reset_sky1_exit);
> 
> 
> 
> > +
> > +MODULE_AUTHOR("Jerry Zhu <jerry.zhu at cixtech.com>");
> > +MODULE_DESCRIPTION("Cix Sky1 reset driver"); MODULE_LICENSE("GPL");
> 
> 
> 
> Best regards,
> Krzysztof