回复: [PATCH 1/3] dt-bindings: reset: add sky1 reset controller

[Gary Yang]

Hi Philipp:

First thanks for your comments

> -----邮件原件-----
> 发件人: Philipp Zabel <p.zabel at pengutronix.de>
> 发送时间: 2025年11月7日 21:25
> 收件人: Gary Yang <gary.yang at cixtech.com>; robh at kernel.org;
> krzk+dt at kernel.org; conor+dt at kernel.org
> 抄送: devicetree at vger.kernel.org; linux-kernel at vger.kernel.org;
> linux-arm-kernel at lists.infradead.org; cix-kernel-upstream
> <cix-kernel-upstream at cixtech.com>
> 主题: Re: [PATCH 1/3] dt-bindings: reset: add sky1 reset controller
> 
> [You don't often get email from p.zabel at pengutronix.de. Learn why this is
> important at https://aka.ms/LearnAboutSenderIdentification ]
> 
> EXTERNAL EMAIL
> 
> CAUTION: Suspicious Email from unusual domain.
> 
> On Fr, 2025-11-07 at 11:38 +0800, Gary Yang wrote:
> > There are two reset controllers on Cix sky1 Soc.
> > One is located in S0 domain, and the other is located in S5 domain.
> >
> > Signed-off-by: Gary Yang <gary.yang at cixtech.com>
> > ---
> >  .../bindings/reset/cix,sky1-rst.yaml          |  48 +++++
> >  include/dt-bindings/reset/cix,sky1-rst-fch.h  |  45 +++++
> >  include/dt-bindings/reset/cix,sky1-rst.h      | 167
> ++++++++++++++++++
> >  3 files changed, 260 insertions(+)
> >  create mode 100644
> > Documentation/devicetree/bindings/reset/cix,sky1-rst.yaml
> >  create mode 100644 include/dt-bindings/reset/cix,sky1-rst-fch.h
> >  create mode 100644 include/dt-bindings/reset/cix,sky1-rst.h
> >
> > diff --git a/Documentation/devicetree/bindings/reset/cix,sky1-rst.yaml
> > b/Documentation/devicetree/bindings/reset/cix,sky1-rst.yaml
> > new file mode 100644
> > index 000000000000..72de480b064c
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/reset/cix,sky1-rst.yaml
> > @@ -0,0 +1,48 @@
> > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) %YAML 1.2
> > +---
> > +$id: http://devicetree.org/schemas/reset/cix,sky1-rst.yaml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: CIX Sky1 Reset Controller
> > +
> > +maintainers:
> > +  - Gary Yang <gary.yang at cixtech.com>
> > +
> > +description: |
> > +  CIX Sky1 reset controller can be used to reset various set of peripherals.
> > +  There are two reset controllers, one is located in S0 domain, the
> > +other
> > +  is located in S5 domain.
> > +
> > +  See also:
> > +  - dt-bindings/reset/cix,sky1-rst.h
> > +
> > +properties:
> > +  compatible:
> > +    items:
> > +      - enum:
> > +          - cix,sky1-rst
> > +          - cix,sky1-rst-fch
> > +      - const: syscon
> 
> Why is this syscon? Is there anything besides reset controls in the register
> space?
> 

Yes, there are some controllers in the register space, for example, a controller used to manager wake up sources.

Best wishes
Gary

> regards
> Philipp