[PATCH v5 3/3] arm64: dts: rockchip: Add devicetree for the 9Tripod X3568 v4

[Chukun Pan]

Hi,

> +++ b/arch/arm64/boot/dts/rockchip/rk3568-9tripod-x3568-v4-camera-demo.dtso
> @@ -0,0 +1,84 @@
> +// SPDX-License-Identifier: (GPL-2.0-or-later OR MIT)
> +
> +// This is a sample reference, due to lack of hardware can not be tested, at your own risk

> +++ b/arch/arm64/boot/dts/rockchip/rk3568-9tripod-x3568-v4-video-demo.dtso
> @@ -0,0 +1,154 @@
> +// SPDX-License-Identifier: (GPL-2.0-or-later OR MIT)
> +
> +// This is a sample reference, due to lack of hardware can not be tested, at your own risk

Why are these demo DT Overlays needed? Are these optional accessories?
These untested DT Overlays should be removed.

> +	vcc3v3_pcie: regulator-vcc3v3-pcie {
> +		compatible = "regulator-gpio";

This should use regulator-fixed.

> +		regulator-name = "vcc3v3_pcie";
> +		regulator-min-microvolt = <100000>;
> +		regulator-max-microvolt = <3300000>;
> +		pinctrl-names = "default";
> +		pinctrl-0 = <&vcc3v3_pcie_en_pin>;

Is this the name from the schematic?

> +	pinctrl-names = "default";
> +	pinctrl-0 = <&gmac0_miim
> +			&gmac0_tx_bus2
> +			&gmac0_rx_bus2
> +			&gmac0_rgmii_clk
> +			&gmac0_rgmii_bus
> +			&gmac0_clkinout>;

> +	pinctrl-names = "default";
> +	pinctrl-0 = <&gmac1m1_miim
> +			&gmac1m1_tx_bus2
> +			&gmac1m1_rx_bus2
> +			&gmac1m1_rgmii_clk
> +			&gmac1m1_rgmii_bus
> +			&gmac1m1_clkinout>;

Align Indentation.

> +		codec {
> +			rockchip,mic-in-differential;
> +		};

Is it confirmed to be differential signaling?

> +	pmic {
> +		pmic_int: pmic_int {
> +			rockchip,pins =
> +				<0 RK_PA3 RK_FUNC_GPIO &pcfg_pull_up>;

No line break is needed here.

> +/* Required remotectl for IR receiver */
> +&pwm7 {
> +	status = "disabled";
> +};

This should be replaced with gpio-ir-receiver.

> +&sdmmc2 {
> +	bus-width = <4>;
> +	disable-wp;

The disable-wp property does not apply to SDIO cards.

> +	sd-uhs-sdr12;
> +	sd-uhs-sdr25;
> +	sd-uhs-sdr50;
> +	sd-uhs-sdr104;

Just declare the highest supported speed.