[PATCH 4/6] crypto: ccp - Constify 'dev_vdata' member
Tom Lendacky
thomas.lendacky at amd.com
Thu Nov 6 12:48:43 PST 2025
On 11/6/25 10:31, Krzysztof Kozlowski wrote:
> sp_device->dev_vdata points to only const data (see 'static const struct
> sp_dev_vdata dev_vdata'), so can be made pointer to const for code
> safety.
>
> Update also sp_get_acpi_version() function which returns this pointer to
> 'pointer to const' for code readability, even though it is not needed.
>
> On the other hand, do not touch similar function sp_get_of_version()
> because it will be immediately removed in next patches.
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski at linaro.org>
Acked-by: Tom Lendacky <thomas.lendacky at amd.com>
> ---
> drivers/crypto/ccp/sp-dev.h | 2 +-
> drivers/crypto/ccp/sp-platform.c | 4 ++--
> 2 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/crypto/ccp/sp-dev.h b/drivers/crypto/ccp/sp-dev.h
> index 6f9d7063257d..1335a83fe052 100644
> --- a/drivers/crypto/ccp/sp-dev.h
> +++ b/drivers/crypto/ccp/sp-dev.h
> @@ -95,7 +95,7 @@ struct sp_device {
>
> struct device *dev;
>
> - struct sp_dev_vdata *dev_vdata;
> + const struct sp_dev_vdata *dev_vdata;
> unsigned int ord;
> char name[SP_MAX_NAME_LEN];
>
> diff --git a/drivers/crypto/ccp/sp-platform.c b/drivers/crypto/ccp/sp-platform.c
> index 3933cac1694d..de8a8183efdb 100644
> --- a/drivers/crypto/ccp/sp-platform.c
> +++ b/drivers/crypto/ccp/sp-platform.c
> @@ -63,13 +63,13 @@ static struct sp_dev_vdata *sp_get_of_version(struct platform_device *pdev)
> return NULL;
> }
>
> -static struct sp_dev_vdata *sp_get_acpi_version(struct platform_device *pdev)
> +static const struct sp_dev_vdata *sp_get_acpi_version(struct platform_device *pdev)
> {
> const struct acpi_device_id *match;
>
> match = acpi_match_device(sp_acpi_match, &pdev->dev);
> if (match && match->driver_data)
> - return (struct sp_dev_vdata *)match->driver_data;
> + return (const struct sp_dev_vdata *)match->driver_data;
>
> return NULL;
> }
>
More information about the linux-arm-kernel
mailing list