[PATCH AUTOSEL 6.17-5.4] ASoC: pxa: add GPIOLIB_LEGACY dependency
Sasha Levin
sashal at kernel.org
Tue Nov 4 05:48:53 PST 2025
On Mon, Oct 27, 2025 at 10:23:35AM +0100, Arnd Bergmann wrote:
>On Sat, Oct 25, 2025, at 17:55, Sasha Levin wrote:
>>
>> LLM Generated explanations, may be completely bogus:
>>
>> YES
>
>It is indeed bogus.
>
>> Rationale
>> - Fixes a real build failure during COMPILE_TEST when legacy GPIO APIs
>> are disabled. The failure stems from `gpio_request_one()` in the PXA
>> AC97 support code: `sound/arm/pxa2xx-ac97-lib.c:374` uses legacy GPIO
>> (gpio_request_one/`GPIOF_OUT_INIT_HIGH`). When `GPIOLIB_LEGACY` is not
>> enabled, these legacy interfaces are not available, leading to the
>> implicit declaration error cited in the commit message.
>
>The build error would only happen after we make GPIOLIB_LEGACY optional,
>but in 6.17 it is still always-enabled.
>
>>
>> Notes on applicability
>> - This backport is most relevant to stable series that already have the
>> `GPIOLIB_LEGACY` split. Older stable trees that predate
>> `GPIOLIB_LEGACY` either won’t need this change (no build break) or may
>> require adjusting the dependency accordingly.
>
>On older kernels, this would actively break configurations that need
>the symbols.
Dropped, thanks!
--
Thanks,
Sasha
More information about the linux-arm-kernel
mailing list