[PATCH net-next v2 0/4] net: altera-tse: Cleanup init sequence
Maxime Chevallier
maxime.chevallier at bootlin.com
Mon Nov 3 02:49:23 PST 2025
Hi, this is a V2 for Altera TSE cleanup to make sure everything is
properly intialized before registering the netdev.
When Altera TSE was converted to phylink, the PCS and phylink creation
were added after register_netdev(), which is wrong as this may race
with .ndo_open() once the netdev is registered.
This series makes so that we register the netdev once all resources are
cleanly initialised, that includes PCS and phylink creation as well as a
few other operations such as reading the IP version.
No errors were found in the wild, so this series doesn't target net, but
given that we fix some racy-ness, a point could be made to send that to
net.
This series doesn't introduce functional changes, however the internal
mii_bus for PCS configuration is renamed.
V2:
- Add Andrew's review tags
- Change patch 2, to get rid of priv->revision and print the core
revision at probe time instead of doing it in .ndo_open()
V1: https://lore.kernel.org/netdev/20251030102418.114518-1-maxime.chevallier@bootlin.com/
Maxime Chevallier (4):
net: altera-tse: Set platform drvdata before registering netdev
net: altera-tse: Warn on bad revision at probe time
net: altera-tse: Don't use netdev name for the PCS mdio bus
net: altera-tse: Init PCS and phylink before registering netdev
drivers/net/ethernet/altera/altera_tse.h | 3 --
drivers/net/ethernet/altera/altera_tse_main.c | 47 +++++++++----------
2 files changed, 23 insertions(+), 27 deletions(-)
--
2.49.0
More information about the linux-arm-kernel
mailing list