[PATCH] drm/bridge: fsl-ldb: Parse register offsets from DT

Marek Vasut marek.vasut at mailbox.org
Sun Nov 2 08:59:48 PST 2025


On 10/20/25 8:21 AM, Liu Ying wrote:

Hello Liu,

>> +++ b/drivers/gpu/drm/bridge/fsl-ldb.c
>> @@ -61,24 +61,16 @@ enum fsl_ldb_devtype {
>>   };
>>   
>>   struct fsl_ldb_devdata {
>> -	u32 ldb_ctrl;
>> -	u32 lvds_ctrl;
>>   	bool lvds_en_bit;
>>   	bool single_ctrl_reg;
> 
> single_ctrl_reg can be dropped then, as it can be expressed by failing to
> get the second register.
> 
> Furthermore, with this done, lvds_en_bit is the only member left and hence
> struct fsl_ldb_devdata can also be dropped, as IIRC there is no need to
> use a structure for device data with only a flag.
I plan to add more bits into the driver match data when adding the MX95, 
so I would like to retain these instead of removing them and the adding 
them back.

The rest is fixed in V2, thanks !



More information about the linux-arm-kernel mailing list