[PATCH 13/13] platform/raspberrypi: vchiq: Register vc-sm-cma as a platform driver

Krzysztof Kozlowski krzk at kernel.org
Sun Nov 2 01:33:55 PST 2025


On 31/10/2025 18:27, Jai Luthra wrote:
> From: Dave Stevenson <dave.stevenson at raspberrypi.com>
> 
> Register the vc-sm-cma driver as a platform driver under vchiq.
> 
> Signed-off-by: Dave Stevenson <dave.stevenson at raspberrypi.com>
> Signed-off-by: Jai Luthra <jai.luthra at ideasonboard.com>
> ---
>  drivers/platform/raspberrypi/vchiq-interface/vchiq_arm.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/platform/raspberrypi/vchiq-interface/vchiq_arm.c b/drivers/platform/raspberrypi/vchiq-interface/vchiq_arm.c
> index 6a7b96d3dae6275a483ef15dc619c5510454765e..09d33bec46ec45175378fff8dd1084d0a8a12dd6 100644
> --- a/drivers/platform/raspberrypi/vchiq-interface/vchiq_arm.c
> +++ b/drivers/platform/raspberrypi/vchiq-interface/vchiq_arm.c
> @@ -63,6 +63,7 @@
>   * the interface.
>   */
>  static struct vchiq_device *bcm2835_audio;
> +static struct vchiq_device *vcsm_cma;

Please don't write singletons. How do you handle probe of two devices?

>  
>  static const struct vchiq_platform_info bcm2835_info = {
>  	.cache_line_size = 32,
> @@ -1421,6 +1422,7 @@ static int vchiq_probe(struct platform_device *pdev)


Best regards,
Krzysztof



More information about the linux-arm-kernel mailing list