[PATCH 01/13] platform/raspberrypi: vchiq-mmal: Avoid use of bool in structures

Krzysztof Kozlowski krzk at kernel.org
Sun Nov 2 01:20:10 PST 2025


On 31/10/2025 18:27, Jai Luthra wrote:
> From: Dave Stevenson <dave.stevenson at raspberrypi.org>
> 
> Fixes up a checkpatch error "Avoid using bool structure members
> because of possible alignment issues".
> 
> Signed-off-by: Dave Stevenson <dave.stevenson at raspberrypi.org>
> Signed-off-by: Jai Luthra <jai.luthra at ideasonboard.com>
> ---
>  drivers/platform/raspberrypi/vchiq-mmal/mmal-vchiq.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/platform/raspberrypi/vchiq-mmal/mmal-vchiq.c b/drivers/platform/raspberrypi/vchiq-mmal/mmal-vchiq.c
> index cd073ed3ea2dd9c45b137f1a32e236e520b7b320..82c2c261fd9cf0669cbd2ca7c814e0703317885a 100644
> --- a/drivers/platform/raspberrypi/vchiq-mmal/mmal-vchiq.c
> +++ b/drivers/platform/raspberrypi/vchiq-mmal/mmal-vchiq.c
> @@ -1776,7 +1776,7 @@ int vchiq_mmal_component_enable(struct vchiq_mmal_instance *instance,
>  
>  	ret = enable_component(instance, component);
>  	if (ret == 0)
> -		component->enabled = true;
> +		component->enabled = 1;
>  

I see no change from bool to unsigned int at all here, so commit msg is
inaccurate or even misleading.

Best regards,
Krzysztof



More information about the linux-arm-kernel mailing list