[PATCH] arch: arm64: dts: add big-endian property back into watchdog node
Li, Meng
Meng.Li at windriver.com
Sat May 31 02:10:02 PDT 2025
> -----Original Message-----
> From: Frank Li <Frank.li at nxp.com>
> Sent: Friday, May 30, 2025 11:11 PM
> To: Li, Meng <Meng.Li at windriver.com>
> Cc: Rob Herring (Arm) <robh at kernel.org>; devicetree at vger.kernel.org;
> shawnguo at kernel.org; linux-kernel at vger.kernel.org; linux-arm-
> kernel at lists.infradead.org; conor+dt at kernel.org
> Subject: Re: [PATCH] arch: arm64: dts: add big-endian property back into
> watchdog node
>
> CAUTION: This email comes from a non Wind River email account!
> Do not click links or open attachments unless you recognize the sender and
> know the content is safe.
>
> On Fri, May 30, 2025 at 02:12:20AM +0000, Li, Meng wrote:
> >
> >
> > > -----Original Message-----
> > > From: Frank Li <Frank.li at nxp.com>
> > > Sent: Friday, May 30, 2025 12:05 AM
> > > To: Li, Meng <Meng.Li at windriver.com>
> > > Cc: Rob Herring (Arm) <robh at kernel.org>; devicetree at vger.kernel.org;
> > > shawnguo at kernel.org; linux-kernel at vger.kernel.org; linux-arm-
> > > kernel at lists.infradead.org; conor+dt at kernel.org
> > > Subject: Re: [PATCH] arch: arm64: dts: add big-endian property back
> > > into watchdog node
> > >
> > > CAUTION: This email comes from a non Wind River email account!
> > > Do not click links or open attachments unless you recognize the
> > > sender and know the content is safe.
> > >
> > > On Thu, May 29, 2025 at 04:07:27AM +0000, Li, Meng wrote:
> > > > Hi Frank,
> > > >
> > > > Do you have any suggestions for this issue?
> > > > Could you please help check whether we need to fix this issue?
> > >
> > > Fix binding doc
> > >
> > > diff --git
> > > a/Documentation/devicetree/bindings/watchdog/fsl-imx-wdt.yaml
> > > b/Documentation/devicetree/bindings/watchdog/fsl-imx-wdt.yaml
> > > index 0da953cb71272..8006efb69ec71 100644
> > > --- a/Documentation/devicetree/bindings/watchdog/fsl-imx-wdt.yaml
> > > +++ b/Documentation/devicetree/bindings/watchdog/fsl-imx-wdt.yaml
> > > @@ -36,6 +36,7 @@ properties:
> > > - fsl,imx8mq-wdt
> > > - fsl,ls1012a-wdt
> > > - fsl,ls1043a-wdt
> > > + - fsl,ls1046a-wdt
> > > - fsl,vf610-wdt
> > > - const: fsl,imx21-wdt
> > >
> > > @@ -103,6 +104,7 @@ allOf:
> > > enum:
> > > - fsl,ls1012a-wdt
> > > - fsl,ls1043a-wdt
> > > + - fsl,ls1046a-wdt
> > >
> > > fix dtsi
> > >
> > > diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi
> > > b/arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi
> > > index 0baf256b44003..096ed81a9bc4d 100644
> > > --- a/arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi
> > > +++ b/arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi
> > > @@ -687,7 +687,7 @@ lpuart5: serial at 29a0000 {
> > > };
> > >
> > > wdog0: watchdog at 2ad0000 {
> > > - compatible = "fsl,imx21-wdt";
> > > + compatible = "fsl,ls1046a-wdt",
> > > + "fsl,imx21-wdt";
> > >
> > >
> >
> > I have a question.
> > I checked the code of ./drivers/watchdog/imx2_wdt.c, there is below
> > item imx2_wdt_dt_ids[] { .compatible = "fsl,ls1043a-wdt", .data =
> > &imx_wdt_legacy }, Do you think we also need to add another below item
> for ls1046?
>
> { .compatible = "fsl,imx21-wdt", .data = &imx_wdt_legacy }, it is enough by use
> fallback fsl,imx21-wdt.
>
> > { .compatible = "fsl,ls1046a-wdt", .data = &imx_wdt_legacy },
> >
> > Another question
> > I also checked the code
> > ./arch/arm64/boot/dts/freescale/fsl-ls1043a.dtsi, and I found out
> > below item in watchdog at 2ad0000 node compatible = "fsl,ls1043a-wdt",
> > "fsl,imx21-wdt"; but in imx2_wdt_dt_ids[], there is also the below
> > item, it also can support the ls1043a and ls1046a platforms { .compatible =
> "fsl,imx21-wdt", .data = &imx_wdt_legacy }, So, I think maybe we can remove
> the { .compatible = "fsl,ls1043a-wdt", .data = &imx_wdt_legacy }.
>
> Yes, but not nessesary to do that. leave it as it.
>
> >
> > Based on above description, there are 2 solutions, add { .compatible =
> "fsl,ls1046a-wdt", .data = &imx_wdt_legacy }, or remove { .compatible =
> "fsl,ls1043a-wdt", .data = &imx_wdt_legacy }.
> > What is your suggestion？
>
> leave driver code unchange. the current driver can work.
>
Ok! Got it.
I have sent v2 patch review.
Thanks,
Limeng
> Frank
>
> >
> > Thanks,
> > LImeng
> >
> >
> >
> > > Frank
> > > >
> > > > Thanks,
> > > > LImeng
> > > >
> > > > > -----Original Message-----
> > > > > From: Rob Herring (Arm) <robh at kernel.org>
> > > > > Sent: Wednesday, May 28, 2025 8:37 PM
> > > > > To: Li, Meng <Meng.Li at windriver.com>
> > > > > Cc: devicetree at vger.kernel.org; shawnguo at kernel.org; linux-
> > > > > kernel at vger.kernel.org; Frank.Li at nxp.com; linux-arm-
> > > > > kernel at lists.infradead.org; conor+dt at kernel.org; Li, Meng
> > > > > <Meng.Li at windriver.com>
> > > > > Subject: Re: [PATCH] arch: arm64: dts: add big-endian property
> > > > > back into watchdog node
> > > > >
> > > > > CAUTION: This email comes from a non Wind River email account!
> > > > > Do not click links or open attachments unless you recognize the
> > > > > sender and know the content is safe.
> > > > >
> > > > > On Wed, 28 May 2025 19:17:51 +0800, Meng Li wrote:
> > > > > > When verifying watchdog feature on NXP ls1046ardb board, it
> > > > > > doesn't work. Because the big-endian is deleted by accident, add it
> back.
> > > > > >
> > > > > > Fixes: 7c8ffc5555cb ("arm64: dts: layerscape: remove
> > > > > > big-endian for mmc nodes")
> > > > > > Cc: stable at vger.kernel.org
> > > > > > Signed-off-by: Meng Li <Meng.Li at windriver.com>
> > > > > > ---
> > > > > > arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi | 1 +
> > > > > > 1 file changed, 1 insertion(+)
> > > > > >
> > > > >
> > > > >
> > > > > My bot found new DTB warnings on the .dts files added or changed
> > > > > in this series.
> > > > >
> > > > > Some warnings may be from an existing SoC .dtsi. Or perhaps the
> > > > > warnings are fixed by another series. Ultimately, it is up to
> > > > > the platform maintainer whether these warnings are acceptable or
> > > > > not. No need to reply unless the platform maintainer has comments.
> > > > >
> > > > > If you already ran DT checks and didn't see these error(s), then
> > > > > make sure dt- schema is up to date:
> > > > >
> > > > > pip3 install dtschema --upgrade
> > > > >
> > > > >
> > > > > This patch series was applied (using b4) to base:
> > > > > Base: attempting to guess base-commit...
> > > > > Base: failed to guess base
> > > > >
> > > > > If this is not the correct base, please add 'base-commit' tag
> > > > > (or use b4 which does this automatically)
> > > > >
> > > > > New warnings running 'make CHECK_DTBS=y for
> > > > > arch/arm64/boot/dts/freescale/' for 20250528111751.3505224-1-
> > > > > Meng.Li at windriver.com:
> > > > >
> > > > > arch/arm64/boot/dts/freescale/fsl-ls1046a-qds.dtb:
> > > > > watchdog at 2ad0000
> > > > > (fsl,imx21-wdt): big-endian: False schema does not allow True
> > > > > from schema $id:
> > > > > http://devicetree.org/schemas/watchdog/fsl-imx-
> > > > > wdt.yaml#
> > > > > arch/arm64/boot/dts/freescale/fsl-ls1046a-frwy.dtb:
> > > watchdog at 2ad0000
> > > > > (fsl,imx21-wdt): big-endian: False schema does not allow True
> > > > > from schema $id:
> > > > > http://devicetree.org/schemas/watchdog/fsl-imx-
> > > > > wdt.yaml#
> > > > > arch/arm64/boot/dts/freescale/fsl-ls1046a-rdb.dtb:
> > > > > watchdog at 2ad0000
> > > > > (fsl,imx21-wdt): big-endian: False schema does not allow True
> > > > > from schema $id:
> > > > > http://devicetree.org/schemas/watchdog/fsl-imx-
> > > > > wdt.yaml#
> > > > > arch/arm64/boot/dts/freescale/fsl-ls1046a-tqmls1046a-
> mbls10xxa.dtb:
> > > > > watchdog at 2ad0000 (fsl,imx21-wdt): big-endian: False schema does
> > > > > not allow True
> > > > > from schema $id:
> > > > > http://devicetree.org/schemas/watchdog/fsl-imx-
> > > > > wdt.yaml#
> > > > >
> > > > >
> > > > >
> > > > >
> > > >
More information about the linux-arm-kernel
mailing list