[PATCH] net: dwmac-rk: No need to check the return value of the phy_power_on()

[Russell King (Oracle)]

On Fri, May 30, 2025 at 09:20:17AM -0700, 李哲 wrote:
> phy_power_on() is a local scope one within the driver, since the return
> value of the phy_power_on() function is always 0, checking its return
> value is redundant.
> 
> Signed-off-by: 李哲 <sensor1010 at 163.com>

Patch looks generally good, nice to see the reverse christmas tree
ordering of local variables resulting from this patch. However, the
subject line needs to be adjusted to meet netdev requirements. Please
see
https://www.kernel.org/doc/html/v5.1/networking/netdev-FAQ.html#q-how-do-i-indicate-which-tree-net-vs-net-next-my-patch-should-be-in
Please wait a minimum of one day before sending an updated version.

Reviewed-by: Russell King (Oracle) <rmk+kernel at armlinux.org.uk>

Please can you also follow up with a patch to change the function name
from "phy_power_on()" as this may conflict with the PHY subsystems
"int phy_power_on(struct phy *phy);"

"rk_phy_power_set()" would probably be a good alternative name,
especially as when the 2nd argument is false, the function turns the
PHY off.

Thanks!

-- 
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!