[PATCH 2/2] arm64: dts: ls1028a: Add mbls1028a and mbls1028a-ind devicetrees

[Frank Li]

On Fri, May 30, 2025 at 08:29:27AM +0200, Alexander Stein wrote:
> Hi Frank,
>
> Am Mittwoch, 28. Mai 2025, 17:35:52 CEST schrieb Frank Li:
> > On Tue, May 27, 2025 at 08:03:55AM +0200, Alexander Stein wrote:
> > > From: Gregor Herburger <gregor.herburger at tq-group.com>
> > >
> > > Add device trees for the MBLS1028A and the MBLS1028A-IND and the SoM
> > > TQMLS1028A.
> > >
> > > Signed-off-by: Gregor Herburger <gregor.herburger at tq-group.com>
> > > Signed-off-by: Alexander Stein <alexander.stein at ew.tq-group.com>
> > > ---
> > >  arch/arm64/boot/dts/freescale/Makefile        |   2 +
> > >  .../fsl-ls1028a-tqmls1028a-mbls1028a-ind.dts  |  68 ++++
> > >  .../fsl-ls1028a-tqmls1028a-mbls1028a.dts      | 118 +++++++
> > >  .../fsl-ls1028a-tqmls1028a-mbls1028a.dtsi     | 291 ++++++++++++++++++
> > >  .../dts/freescale/fsl-ls1028a-tqmls1028a.dtsi | 117 +++++++
> >
> > New dts file, suggest run https://github.com/lznuaa/dt-format to nice order
>
> Thanks for the suggestions. It does some improvements, but I also disagree
> with a lot of proposed changes:
> * Wrong indent of SPDX tag
> * model property should come first IMHO
> * {gpio,interrupt}-controller should come before #{gpio,interrupt}-cells

I checked code, it is specific rule to make -cells before -controller. It
should come from previous review comments.

Do you have document or mail list require -controller before --cells ?

Frank

> * gpio-hog property should come first in a hog node
> * sorting gpio-hog nodes by name instead of line number seems wrong
>
> There are some more bogus changes, so I'll skip this tool for now.
>
> Thanks & best regards
> Alexander
>
> > Frank
> > [...]
> --
> TQ-Systems GmbH | Mühlstraße 2, Gut Delling | 82229 Seefeld, Germany
> Amtsgericht München, HRB 105018
> Geschäftsführer: Detlef Schneider, Rüdiger Stahl, Stefan Schneider
> http://www.tq-group.com/
>
>