[PATCH v4 1/2] perf: Fujitsu: Add the Uncore MAC PMU driver

Koichi Okuno (Fujitsu) fj2767dz at fujitsu.com
Fri May 30 02:16:41 PDT 2025


Hi, Jonathan

Sorry for the late reply.

> > Hi, Jonathan
> > 
> > Sorry for the late reply.
> > Also, the person in charge here has changed from Furudera to Okuno.
> > 
> Hi,
> 
> 
> > > > Text identical to memory-pwrite-count
> > > > which suggest two things.
> > > > a) naming inconsistent.  Why is mac mentioned here and not in the name  
> > > earlier.  
> > > > b) This comment is perhaps wrong as I assume has something more tod owtih  
> > > with  
> > > >    energy estimation?  
> > > 
> > > We are currently checking and will reply later.  
> > 
> > After checking with the hardware team,
> > the 'ea' events are measured at different points and may therefore 
> > return different values.
> > Since memory-pwrite-count and ea-memory-mac-pwrite currently return 
> > the same value, they share the same description.
> > However, we have defined distinct event names to accommodate potential 
> > future enhancements.
> 
> As any future enhancement to make these different will also need a change
> to the documentation to reflect that difference (and hence a kernel patch)
> maybe it is better to not provide the second event for now?
> 
> Or is there some other subtle effect to do with groups that can be enabled
> at the same time? I've forgotten how the driver works!
> 
> Jonathan

After discussing with the hardware team,
delete EA events that share the same description as a MAC event.
Change MAC events with the same description to a different description.
If there are no issues, We plan to submit the v5 patch series with this fix.

Best Regards,
Koichi Okuno


More information about the linux-arm-kernel mailing list