[PATCH] arch: arm64: dts: add big-endian property back into watchdog node
Li, Meng
Meng.Li at windriver.com
Wed May 28 22:50:03 PDT 2025
> -----Original Message-----
> From: Frank Li <Frank.li at nxp.com>
> Sent: Thursday, May 29, 2025 12:11 AM
> To: Li, Meng <Meng.Li at windriver.com>
> Cc: shawnguo at kernel.org; robh at kernel.org; conor+dt at kernel.org; linux-arm-
> kernel at lists.infradead.org; devicetree at vger.kernel.org; linux-
> kernel at vger.kernel.org
> Subject: Re: [PATCH] arch: arm64: dts: add big-endian property back into
> watchdog node
>
> CAUTION: This email comes from a non Wind River email account!
> Do not click links or open attachments unless you recognize the sender and
> know the content is safe.
>
> On Wed, May 28, 2025 at 07:17:51PM +0800, Meng Li wrote:
> > When verifying watchdog feature on NXP ls1046ardb board, it doesn't
> > work. Because the big-endian is deleted by accident, add it back.
> >
> > Fixes: 7c8ffc5555cb ("arm64: dts: layerscape: remove big-endian for
> > mmc nodes")
>
> fix tags should be wrong.
>
> I remember I tested without big-endian. If it is wrong, please revert original
> patch and provide enough reason.
>
Although you said you understand my patch in your next email, do you think I still need to improve my commit log more clearly, and send a v2 patch?
For example, describe that only the big-endian of watchdog node is remove by accident, and the mmc works fine. Only add the big-endian for watchdog feature.
Thanks,
Limeng
> Frank
>
> > Cc: stable at vger.kernel.org
> > Signed-off-by: Meng Li <Meng.Li at windriver.com>
> > ---
> > arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi
> > b/arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi
> > index 4d75bff0d548..e15ec2e1cb04 100644
> > --- a/arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi
> > +++ b/arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi
> > @@ -753,6 +753,7 @@ wdog0: watchdog at 2ad0000 {
> > interrupts = <GIC_SPI 83 IRQ_TYPE_LEVEL_HIGH>;
> > clocks = <&clockgen QORIQ_CLK_PLATFORM_PLL
> > QORIQ_CLK_PLL_DIV(2)>;
> > + big-endian;
> > };
> >
> > edma0: dma-controller at 2c00000 {
> > --
> > 2.34.1
> >
More information about the linux-arm-kernel
mailing list