[PATCH v2 08/11] arm64: debug: split hardware watchpoint exception entry

[Ada Couprie Diaz]

On 20/05/2025 17:59, Will Deacon wrote:

> On Mon, May 12, 2025 at 06:43:23PM +0100, Ada Couprie Diaz wrote:
>> [...]
>> diff --git a/arch/arm64/kernel/entry-common.c b/arch/arm64/kernel/entry-common.c
>> index 8814ad24e707..6e70130d2741 100644
>> --- a/arch/arm64/kernel/entry-common.c
>> +++ b/arch/arm64/kernel/entry-common.c
>> @@ -530,10 +530,20 @@ static void noinstr el1_softstp(struct pt_regs *regs, unsigned long esr)
>>   	arm64_exit_el1_dbg(regs);
>>   }
>>   
>> -static void noinstr el1_dbg(struct pt_regs *regs, unsigned long esr)
>> +static void noinstr el1_watchpt(struct pt_regs *regs, unsigned long esr)
>>   {
>> +	/* Only watchpoints write FAR_EL1 */
> nit: But maybe scope the comment (here and in the el0 handler) for debug
> exceptions?
> e.g.
>
> 	/* Watchpoints are the only debug exception to write FAR_EL1 */
>
> ?
>
> Will

Good point. The comment felt somewhat off to me and that's exactly why.

Updated the wording for v3, thanks.

Ada