[PATCH 1/6] pinctrl: airoha: fix wrong PHY LED mux value for LED1 GPIO46
Lorenzo Bianconi
lorenzo at kernel.org
Wed May 28 00:16:04 PDT 2025
> In all the MUX value for LED1 GPIO46 there is a Copy-Paste error where
> the MUX value is set to LED0_MODE_MASK instead of LED1_MODE_MASK.
>
> This wasn't notice as there were no board that made use of the
> secondary PHY LED but looking at the internal Documentation the actual
> value should be LED1_MODE_MASK similar to the other GPIO entry.
>
> Fix the wrong value to apply the correct MUX configuration.
Acked-by: Lorenzo Bianconi <lorenzo at kernel.org>
>
> Cc: stable at vger.kernel.org
> Fixes: 1c8ace2d0725 ("pinctrl: airoha: Add support for EN7581 SoC")
> Signed-off-by: Christian Marangi <ansuelsmth at gmail.com>
> ---
> drivers/pinctrl/mediatek/pinctrl-airoha.c | 16 ++++++++--------
> 1 file changed, 8 insertions(+), 8 deletions(-)
>
> diff --git a/drivers/pinctrl/mediatek/pinctrl-airoha.c b/drivers/pinctrl/mediatek/pinctrl-airoha.c
> index b97b28ebb37a..8ef7f88477aa 100644
> --- a/drivers/pinctrl/mediatek/pinctrl-airoha.c
> +++ b/drivers/pinctrl/mediatek/pinctrl-airoha.c
> @@ -1752,8 +1752,8 @@ static const struct airoha_pinctrl_func_group phy1_led1_func_group[] = {
> .regmap[0] = {
> AIROHA_FUNC_MUX,
> REG_GPIO_2ND_I2C_MODE,
> - GPIO_LAN3_LED0_MODE_MASK,
> - GPIO_LAN3_LED0_MODE_MASK
> + GPIO_LAN3_LED1_MODE_MASK,
> + GPIO_LAN3_LED1_MODE_MASK
> },
> .regmap[1] = {
> AIROHA_FUNC_MUX,
> @@ -1816,8 +1816,8 @@ static const struct airoha_pinctrl_func_group phy2_led1_func_group[] = {
> .regmap[0] = {
> AIROHA_FUNC_MUX,
> REG_GPIO_2ND_I2C_MODE,
> - GPIO_LAN3_LED0_MODE_MASK,
> - GPIO_LAN3_LED0_MODE_MASK
> + GPIO_LAN3_LED1_MODE_MASK,
> + GPIO_LAN3_LED1_MODE_MASK
> },
> .regmap[1] = {
> AIROHA_FUNC_MUX,
> @@ -1880,8 +1880,8 @@ static const struct airoha_pinctrl_func_group phy3_led1_func_group[] = {
> .regmap[0] = {
> AIROHA_FUNC_MUX,
> REG_GPIO_2ND_I2C_MODE,
> - GPIO_LAN3_LED0_MODE_MASK,
> - GPIO_LAN3_LED0_MODE_MASK
> + GPIO_LAN3_LED1_MODE_MASK,
> + GPIO_LAN3_LED1_MODE_MASK
> },
> .regmap[1] = {
> AIROHA_FUNC_MUX,
> @@ -1944,8 +1944,8 @@ static const struct airoha_pinctrl_func_group phy4_led1_func_group[] = {
> .regmap[0] = {
> AIROHA_FUNC_MUX,
> REG_GPIO_2ND_I2C_MODE,
> - GPIO_LAN3_LED0_MODE_MASK,
> - GPIO_LAN3_LED0_MODE_MASK
> + GPIO_LAN3_LED1_MODE_MASK,
> + GPIO_LAN3_LED1_MODE_MASK
> },
> .regmap[1] = {
> AIROHA_FUNC_MUX,
> --
> 2.48.1
>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 228 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20250528/b36ce473/attachment.sig>
More information about the linux-arm-kernel
mailing list