[PATCH v2 2/2] ethernet: eswin: Add eic7700 ethernet driver

[Krzysztof Kozlowski]

On 28/05/2025 06:16, weishangjuan at eswincomputing.com wrote:
> +static int eswin_qos_probe(struct platform_device *pdev,
> +			   struct plat_stmmacenet_data *plat_dat,
> +			   struct stmmac_resources *stmmac_res)
> +{
> +	struct eswin_qos_priv *dwc_priv;
> +	u32 hsp_aclk_ctrl_offset;
> +	u32 hsp_aclk_ctrl_regset;
> +	u32 hsp_cfg_ctrl_offset;
> +	u32 eth_axi_lp_ctrl_offset;
> +	u32 eth_phy_ctrl_offset;
> +	u32 eth_phy_ctrl_regset;
> +	struct clk *clk_app;
> +	int ret;
> +	int err;
> +
> +	dwc_priv = devm_kzalloc(&pdev->dev, sizeof(*dwc_priv), GFP_KERNEL);
> +	if (!dwc_priv)
> +		return -ENOMEM;
> +
> +	if (device_property_read_u32(&pdev->dev, "id", &dwc_priv->dev_id))

NAK, you cannot have undocumented ABI. You did not test your DTS.

Best regards,
Krzysztof