[PATCH 02/10] PCI: exynos: Remove unused MACROs in exynos PCI file
Shradha Todi
shradha.t at samsung.com
Tue May 27 03:42:31 PDT 2025
> -----Original Message-----
> From: Krzysztof Kozlowski <krzk at kernel.org>
> Sent: 21 May 2025 15:11
> To: Shradha Todi <shradha.t at samsung.com>
> Cc: linux-pci at vger.kernel.org; devicetree at vger.kernel.org; linux-arm-kernel at lists.infradead.org; linux-samsung-soc at vger.kernel.or;
> linux-kernel at vger.kernel.org; linux-phy at lists.infradead.org; manivannan.sadhasivam at linaro.org; lpieralisi at kernel.org;
> kw at linux.com; robh at kernel.org; bhelgaas at google.com; jingoohan1 at gmail.com; krzk+dt at kernel.org; conor+dt at kernel.org;
> alim.akhtar at samsung.com; vkoul at kernel.org; kishon at kernel.org; arnd at arndb.de; m.szyprowski at samsung.com;
> jh80.chung at samsung.com; Hrishikesh Dileep <hrishikesh.d at samsung.com>
> Subject: Re: [PATCH 02/10] PCI: exynos: Remove unused MACROs in exynos PCI file
>
> On Mon, May 19, 2025 at 01:01:44AM GMT, Shradha Todi wrote:
> > Some MACROs are defined in the exynos PCI file but are not used
> > anywhere within the file. Remove such unused MACROs.
> >
> > Suggested-by: Hrishikesh Dileep <hrishikesh.d at samsung.com>
> > Signed-off-by: Shradha Todi <shradha.t at samsung.com>
> > ---
> > drivers/pci/controller/dwc/pci-exynos.c | 2 --
> > 1 file changed, 2 deletions(-)
> >
> > diff --git a/drivers/pci/controller/dwc/pci-exynos.c
> > b/drivers/pci/controller/dwc/pci-exynos.c
> > index 1c70b036376d..990aaa16b132 100644
> > --- a/drivers/pci/controller/dwc/pci-exynos.c
> > +++ b/drivers/pci/controller/dwc/pci-exynos.c
> > @@ -31,8 +31,6 @@
> > #define EXYNOS_IRQ_INTB_ASSERT BIT(2)
> > #define EXYNOS_IRQ_INTC_ASSERT BIT(4)
> > #define EXYNOS_IRQ_INTD_ASSERT BIT(6)
> > -#define EXYNOS_PCIE_IRQ_LEVEL 0x004
>
> Fix order of patches. Why renaming something just to remove it? No point.
>
This makes sense. Will change it
> Best regards,
> Krzysztof
More information about the linux-arm-kernel
mailing list