[PATCH v6 2/2] coresight: add coresight Trace Network On Chip driver

[Leo Yan]

On Fri, May 23, 2025 at 04:08:58PM +0800, Yuanfang Zhang wrote:

[...]

> >> +static int trace_noc_init_default_data(struct trace_noc_drvdata *drvdata)
> >> +{
> >> +    int atid;
> >> +
> >> +    atid = coresight_trace_id_get_system_id();
> >> +    if (atid < 0)
> >> +        return atid;
> >> +
> >> +    drvdata->atid = atid;
> > 
> > Do you need to expose this via sysfs ? Otherwise, how can you map
> > a trace to a TNOC at decoding ?
> 
> yes, need to expose the atid via sysfs, but it better to expose it on source driver which connect with
> this TNOC. so dont expose it on this driver.

If so, why the ID is not maintained in coresight_path::trace_id?

A source device allocates ID and maintains in coresight path, then
this ID is passed (when enabling the link) to TNOC driver to consume it.

Thanks,
Leo