[PATCH v2] firmware: arm_scmi: Use dev_err_probe() simplify the code
Krzysztof Kozlowski
krzk at kernel.org
Thu May 22 01:41:37 PDT 2025
On 21/05/2025 10:14, long.yunjian at zte.com.cn wrote:
> From: Yumeng Fang <fang.yumeng at zte.com.cn>
>
> In the probe path, dev_err() can be replaced with dev_err_probe()
That's mailbox channel setup, not probe path.
Either this patch is wrong or commit msg is just not relevant.
> which will check if error code is -EPROBE_DEFER and prints the
> error name. It also sets the defer probe reason which can be
> checked later through debugfs.
You explain the basic stuff, we all know it, but you miss to explain
things which we do not know. Rewrite your commit msgs to explain the
non-obvious.
We all know how dev_err_probe works. What we do not know is ALWAYS that
chan setup is the probe path (so prove that it is ALWAYS probe path).
Best regards,
Krzysztof
More information about the linux-arm-kernel
mailing list