[PATCH v3 2/3] net: can: rockchip: add can for RK3576 Soc

Vincent Mailhol mailhol.vincent at wanadoo.fr
Thu May 22 00:51:40 PDT 2025


On Thu. 22 May 2025 at 15:38, Elaine Zhang <zhangqing at rock-chips.com> wrote:
>
> Is new controller:
> Support CAN and CANFD protocol.
> Support Dma.

Please write a more verbose description with proper sentences.

> Signed-off-by: Elaine Zhang <zhangqing at rock-chips.com>

You need to break this into several patches and several files.

You can not put everything in rockchip_canfd-core.c. Create a
rockchip_rk3568.c in which you will move all the already existing
rk3568 specific functions. Then, in another patch, create a
rockchip_rk3576.c that will contain all the new code. Also adjust the
headers accordingly.


Yours sincerely,
Vincent Mailhol



More information about the linux-arm-kernel mailing list