[PATCH v2 2/2] phy: exyons5-usbdrd: support HS phy for ExynosAutov920

[Krzysztof Kozlowski]

On 21/05/2025 14:56, 'Neil Armstrong' wrote:
>>> <snip>
>>>
>>>> +	}, {
>>>> +		.compatible = "samsung,exynosautov920-usb31drd-phy",
>>>> +		.data = &exynosautov920_usb31drd_phy
>>>
>>> All those new ops are only called when matching this compatible, it it really
>>> necessary to check the version ? is there "samsung,exynosautov920-usb31drd-
>>> phy" PHYs with version different from 3 in the wild ?
>>>
>>
>> This SoC has a single USB 3.1 DRD combo phy of version v400 (major : minor versions) and three USB2.0
>> DRD phy v303 (major : minor versions) controllers those only support the UTMI+ interface. Currently,
>> supporting only v303 phys in this patch-set, and planning v400 phy later (soon).
>>
>> Yes, there's v400 phy version that is different from v303 phy. Hence, phy version check is needed to support both the phys for same compatible.
> 
> OK so add 2 compatibles, one for the usb31drd and one for the usb2drd since those are 2 difference hardware.

...unless this is fully detectable hardware, then use fallbacks and only
one compatible in the driver.

Best regards,
Krzysztof