[PATCH 3/3] ARM: dts: mxs: support i.MX28 Amarula rmm board

[Fabio Estevam]

Hi Dario,

On Wed, May 21, 2025 at 6:28 AM Dario Binacchi
<dario.binacchi at amarulasolutions.com> wrote:
>
> The board includes the following resources:
>  - 256 Mbytes NAND Flash
>  - 256 Mbytes SRAM

SRAM or DDR?

>  - LCD-TFT controller

The LCD support is not described in the dts.

> +/ {
> +       model = "Amarula i.MX28 rmm";
> +       compatible = "amarula,imx28-rmm", "fsl,imx28";
> +
> +       memory at 40000000 {
> +               device_type = "memory";
> +               reg = <0x40000000 0x08000000>;

In the commit log, you say 256 MB, but here we have 128 MB.

> +&i2c0 {
> +       pinctrl-names = "default";
> +       pinctrl-0 = <&i2c0_pins_a>;
> +       status = "okay";
> +
> +       polytouch: edt-ft5x06 at 38 {

Node names should be generic: touchscreen at 38

> +
> +&pinctrl {
> +       pinctrl-names = "default";
> +       pinctrl-0 = <&hog_pins_a>;
> +
> +       hog_pins_a: hog-0 {
> +               reg = <0>;
> +               fsl,pinmux-ids = <
> +                       MX28_PAD_LCD_RESET__GPIO_3_30 /* LCD reset */
> +                       MX28_PAD_SSP2_SS1__GPIO_2_20  /* External power */

Proper panel bindings should better describe these pins than hog pins.

Do you plan to add display support?