[PATCH 3/3] media: allegro-dvt: Add DT-bindings for the Gen 3 IP
Krzysztof Kozlowski
krzk at kernel.org
Wed May 14 01:01:14 PDT 2025
On 12/05/2025 13:17, Yassine Ouaissa wrote:
> On 12.05.2025 12:42, Krzysztof Kozlowski wrote:
>> On Mon, May 12, 2025 at 08:23:11AM GMT, Yassine Ouaissa wrote:
>>> issue fixed also, thanks.
>>>>> + significant advancements over its predecessors. This new decoder features
>>>>> + enhanced processing capabilities with improved throughput and reduced latency.
>>>>> +
>>>>> + Communication between the host driver software and the MCU is implemented through
>>>>> + a specialized mailbox interface mechanism. This mailbox system provides a
>>>>> + structured channel for exchanging commands, parameters, and status information
>>>>> + between the host CPU and the MCU controlling the codec engines.
>>>>> +
>>>>> +properties:
>>>>> + compatible:
>>>>> + const: allegrodvt,al300-vdec
>>>>
>>>> Undocumented prefix.
>>>>
>>>> What is the actual device name? al300? Can you have al300-adec? or
>>>> al300-dec?
>>>>
>>>>
>>>
>>> the device name is al300, the vdec is for decoder driver.
>>
>> So drop vdec. Compatible should reflect device name.
>>
>
> We cannot, the IP could have the encode and decode in the same time.
> the al300 is for the IP gen, and vdec/venc for the driver compatible.
>
> I'll discuss with the team, about other naming.
Do not send next version - like you did now - before we finish
discussion. You just sent the same bypassing this entire discussion.
Explain what is the device name, what is the device so we can understand it.
I also expect all other comments to be implemented - including
clock-names and incorrect device node name.
Best regards,
Krzysztof
More information about the linux-arm-kernel
mailing list