[PATCH 1/7] pinctrl: armada-37xx: use correct OUTPUT_VAL register for GPIOs > 31

Andrew Lunn andrew at lunn.ch
Mon May 12 14:28:25 PDT 2025


On Mon, May 12, 2025 at 04:22:37PM +0200, Gabor Juhos wrote:
> The controller has two consecutive OUTPUT_VAL registers and both
> holds output value for 32 GPIOs. Due to a missing adjustment, the
> current code always uses the first register while setting the
> output value whereas it should use the second one for GPIOs > 31.
> 
> Add the missing armada_37xx_update_reg() call to adjust the register
> according to the 'offset' parameter of the function to fix the issue.
> 
> Cc: stable at vger.kernel.org
> Fixes: 6702abb3bf23 ("pinctrl: armada-37xx: Fix direction_output() callback behavior")
> Signed-off-by: Gabor Juhos <j4g8y7 at gmail.com>
> Signed-off-by: Imre Kaloz <kaloz at openwrt.org>

Reviewed-by: Andrew Lunn <andrew at lunn.ch>

    Andrew



More information about the linux-arm-kernel mailing list