[PATCH v2 1/6] dt-bindings: mfd: add bindings for QIXIS CPLD

[Krzysztof Kozlowski]

On Fri, May 09, 2025 at 06:29:35PM GMT, Ioana Ciornei wrote:
> This adds device tree bindings for the board management controller -

"Add devicetree bindings...."

Please do not use "This commit/patch/change", but imperative mood. See
longer explanation here:
https://elixir.bootlin.com/linux/v5.17.1/source/Documentation/process/submitting-patches.rst#L95

> QIXIS CPLD - found on some Layerscape based boards such as LX2162A-QDS,
> LX2160AQDS, LS1028AQDS etc.
> 

...

> +title: NXP's QIXIS CPLD board management controller
> +
> +maintainers:
> +  - Ioana Ciornei <ioana.ciornei at nxp.com>
> +
> +description: |

Do not need '|' unless you need to preserve formatting.

> +  The board management controller found on some Layerscape boards contains
> +  different IP blocks like GPIO controllers, interrupt controllers, reg-muxes
> +  etc. The QIXIS CPLD on these boards presents itself as an I2C device.
> +
> +properties:
> +  compatible:
> +    enum:
> +      - fsl,ls1028a-qds-qixis-cpld
> +      - fsl,lx2160a-qds-qixis-cpld
> +      - fsl,lx2162a-qds-qixis-cpld

I think my question why existing compatibles cannot work is still valid.
If you responded to that and I missed reply, please point me, but I see
I replied on 7th May and you sent it later - on 9th May.

> +
> +  reg:
> +    maxItems: 1
> +
> +  "#address-cells":
> +    const: 1
> +
> +  "#size-cells":
> +    const: 0
> +
> +patternProperties:
> +  '^mux-controller(@[a-f0-9]+)?$':

Either children have bus addressing or not. This should not be flexible,
because rarely devices differ. If devices differ, then you need separate
schema most likely.

> +    $ref: /schemas/mux/reg-mux.yaml#
> +
> +required:
> +  - compatible
> +  - reg
> +  - "#address-cells"
> +  - "#size-cells"

Best regards,
Krzysztof