[PATCH 2/7] pinctrl: armada-37xx: propagate error from armada_37xx_gpio_direction_output()
Gabor Juhos
j4g8y7 at gmail.com
Mon May 12 07:22:38 PDT 2025
The regmap_update_bits() function can fail, so propagate its error
up to the stack instead of silently ignoring that.
Cc: stable at vger.kernel.org
Fixes: 6702abb3bf23 ("pinctrl: armada-37xx: Fix direction_output() callback behavior")
Signed-off-by: Gabor Juhos <j4g8y7 at gmail.com>
Signed-off-by: Imre Kaloz <kaloz at openwrt.org>
---
drivers/pinctrl/mvebu/pinctrl-armada-37xx.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/pinctrl/mvebu/pinctrl-armada-37xx.c b/drivers/pinctrl/mvebu/pinctrl-armada-37xx.c
index 43034d29292687e875136aafa530b62479dc55ec..e0c8eebf40588a1b49b80e2a1ddcc2a35fa7c07b 100644
--- a/drivers/pinctrl/mvebu/pinctrl-armada-37xx.c
+++ b/drivers/pinctrl/mvebu/pinctrl-armada-37xx.c
@@ -433,9 +433,7 @@ static int armada_37xx_gpio_direction_output(struct gpio_chip *chip,
armada_37xx_update_reg(®, &val_offset);
val = value ? mask : 0;
- regmap_update_bits(info->regmap, reg, mask, val);
-
- return 0;
+ return regmap_update_bits(info->regmap, reg, mask, val);
}
static int armada_37xx_gpio_get(struct gpio_chip *chip, unsigned int offset)
--
2.49.0
More information about the linux-arm-kernel
mailing list