[PATCH net-next] net: ixp4xx_eth: convert to ndo_hwtstamp_get() and ndo_hwtstamp_set()

[Vladimir Oltean]

On Thu, May 08, 2025 at 11:45:48PM +0100, Vadim Fedorenko wrote:
> > The remainder of eth_ioctl() is exactly equivalent to
> > phy_do_ioctl_running(), so use that.
> 
> One interesting fact is that phy_do_ioctl_running() will return -ENODEV
> in case of !netif_running(netdev) while previous code would return
> -EINVAL. Probably it's ok, but may be it's better to have consistent
> error path for both options.
> 
> Otherwise LGTM,
> Reviewed-by: Vadim Fedorenko <vadim.fedorenko at linux.dev>

Thanks for the review. Indeed, I hadn't noticed the -EINVAL vs -ENODEV
difference.

Are you suggesting that I first create a patch which replaces -EINVAL
with -ENODEV in eth_ioctl(), so that ixp4xx_hwtstamp_get/set() is
consistent with phy_do_ioctl_running() in returning -ENODEV?