[PATCH v1 09/14] arm64: dts: mediatek: mt7988: add switch node
Daniel Golle
daniel at makrotopia.org
Sun May 11 14:55:50 PDT 2025
On Sun, May 11, 2025 at 11:25:27PM +0200, Andrew Lunn wrote:
> > i will move that into the board dtsi file in v2 because "normal" bpi-r4 and 2g5 variant are same here.
>
> Maybe you just need to expand the commit message? What does this .dtsi
> actually represent? The SoC, or what is common across a number of
> boards?
mt7988a.dtsi represents the SoC, and thus there shouldn't be any
labels assigned to the DSA ports.
In case of the BananaPi R4 there are two different boards, one with 2x
SFP+ and one with 1x SFP+ + 1x 2500Base-T (with PoE-in), hence there is
a dtsi files for all the parts shared among the two boards. I suppose
Frank meant to move the labels to that board dtsi file, and that's
correct imho as the labels of the 1G switch ports are the same on BPi-R4
and BPi-R4-PoE.
More information about the linux-arm-kernel
mailing list