[PATCH] ASPEED: bmc: Add device tree for Meta(Facebook) Clemente compute-tray.
Krzysztof Kozlowski
krzysztof.kozlowski at linaro.org
Fri May 9 04:36:01 PDT 2025
On 09/05/2025 10:59, leo.jt.wang at gmail.com wrote:
> From: Leo Wang <leo.jt.wang at fii-foxconn.com>
>
> Signed-off-by: Leo Wang <leo.jt.wang at fii-foxconn.com>
Please run scripts/checkpatch.pl on the patches and fix reported
warnings. After that, run also 'scripts/checkpatch.pl --strict' on the
patches and (probably) fix more warnings. Some warnings can be ignored,
especially from --strict run, but the code here looks like it needs a
fix. Feel free to get in touch if the warning is not clear.
Please use subject prefixes matching the subsystem. You can get them for
example with `git log --oneline -- DIRECTORY_OR_FILE` on the directory
your patch is touching. For bindings, the preferred subjects are
explained here:
https://www.kernel.org/doc/html/latest/devicetree/bindings/submitting-patches.html#i-for-patch-submitters
You CC-ed an address, which suggests you do not work on mainline kernel
or you do not use get_maintainers.pl/b4/patman. Please rebase and always
work on mainline or start using mentioned tools, so correct addresses
will be used.
...
> +&io_expander13 {
> + gpio-line-names =
> + "rmc_en_dc_pwr_on","",
> + "","",
> + "","",
> + "","",
> + "leak_config_0","leak_config_1",
> + "leak_config_2","leak_config_3",
> + "mfg_led_test_mode_l","small_leak_err_inj",
> + "large_leak_err_inj","";
> +};
> \ No newline at end of file
You have patch warning.
Best regards,
Krzysztof
More information about the linux-arm-kernel
mailing list