[PATCH 1/1] soc: ti: wkup_m3_ipc: Use dev_err_probe

Dhruva Gole d-gole at ti.com
Fri May 9 04:32:38 PDT 2025


On May 09, 2025 at 11:36:52 +0200, Alexander Stein wrote:
> During probe the mailbox channel might not yet be available. Use
> dev_err_probe to silence this deferred probe error message:
> wkup_m3_ipc 44e11324.wkup_m3_ipc: IPC Request for A8->M3 Channel failed! -517
> 
> Signed-off-by: Alexander Stein <alexander.stein at ew.tq-group.com>
> ---
>  drivers/soc/ti/wkup_m3_ipc.c | 8 +++-----
>  1 file changed, 3 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/soc/ti/wkup_m3_ipc.c b/drivers/soc/ti/wkup_m3_ipc.c
> index 79dde9a7ec639..5845fc652adcf 100644
> --- a/drivers/soc/ti/wkup_m3_ipc.c
> +++ b/drivers/soc/ti/wkup_m3_ipc.c
> @@ -644,11 +644,9 @@ static int wkup_m3_ipc_probe(struct platform_device *pdev)
>  
>  	m3_ipc->mbox = mbox_request_channel(&m3_ipc->mbox_client, 0);
>  
> -	if (IS_ERR(m3_ipc->mbox)) {
> -		dev_err(dev, "IPC Request for A8->M3 Channel failed! %ld\n",
> -			PTR_ERR(m3_ipc->mbox));
> -		return PTR_ERR(m3_ipc->mbox);
> -	}
> +	if (IS_ERR(m3_ipc->mbox))
> +		return dev_err_probe(dev, PTR_ERR(m3_ipc->mbox),
> +				     "IPC Request for A8->M3 Channel failed!\n");

Reviewed-by: Dhruva Gole <d-gole at ti.com>

-- 
Best regards,
Dhruva Gole
Texas Instruments Incorporated



More information about the linux-arm-kernel mailing list