[PATCH] cpuidle: psci: Avoid initializing faux device if no DT idle states are present

Rafael J. Wysocki rafael at kernel.org
Wed May 7 07:58:48 PDT 2025


Hi Sudeep,

On Wed, May 7, 2025 at 3:56 PM Sudeep Holla <sudeep.holla at arm.com> wrote:
>
> Hi Rafael,
>
> On Fri, May 02, 2025 at 03:01:19PM +0100, Sudeep Holla wrote:
> > Commit af5376a77e87 ("cpuidle: psci: Transition to the faux device interface")
> > transitioned the PSCI cpuidle driver from using a platform device to the
> > faux device framework. However, unlike platform devices, the faux device
> > infrastructure logs an error when the probe function fails, even if the
> > failure is intentional or expected.
> >
> > To prevent unnecessary error logs, we can skip creating the faux device
> > entirely if there are no PSCI idle states defined in the device tree.
> > Introduce a check for DT idle states during initialization and avoid
> > setting up the device if none are found.
> >
> > This ensures cleaner logs and avoids misleading probe failure messages
> > when PSCI idle support is intentionally not described in DT.
> >
>
> As you pointed out in another similar fix that exist only in the linux-next,
> I have also missed to point out that fact here. This is only present in
> the next. Let me know if you want me to drop the commit hash reference
> and repost it with -next prefix which I generally do and somehow clearly
> missed here. Sorry for that.

No worries.

The cpuidle branch hasn't changed, so this is applicable with no changes.

Applied now, thanks!



More information about the linux-arm-kernel mailing list